Enforce metadata_stradegy as extended #379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can it be closed? |
|
I think we should still do this. This should be the default and if needed we should opt-out. |
kysrpex
changed the title
|
At the moment, we are enforcing this through TPV in tool_defaults.yml. Since our only destinations on the job conf are local and tpv_dispatcher, I guess it makes sense to enable this on a global level. What do you think? |
|
Looking at destinations.yml.j2, Pulsar seems to require Again the TPV dry-run failure is normal and expected. The dry-run fails for the default tool because mock tools have no version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set metadata_strategy to be 'extended' on a global level.
This will fix #369
The next step would be to clean the destination ... but this is optional.